Re: [PATCH v6 4/5] device property: Constify fwnode_handle_get()
From: kernel test robot
Date: Fri Apr 08 2022 - 23:40:17 EST
Hi Andy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on rafael-pm/linux-next robh/for-next linus/master v5.18-rc1 next-20220408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220409-025056
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220409/202204091133.KMBmLNSx-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/477683439b5ee0954b08970d8c356b4cdaca8bc0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220409-025056
git checkout 477683439b5ee0954b08970d8c356b4cdaca8bc0
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash drivers/base/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/base/property.c: In function 'fwnode_handle_get':
>> drivers/base/property.c:782:24: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
782 | return fwnode;
| ^~~~~~
vim +/const +782 drivers/base/property.c
613e97218ccbd7f Adam Thomson 2016-06-21 772
e7887c284969a23 Sakari Ailus 2017-03-28 773 /**
e7887c284969a23 Sakari Ailus 2017-03-28 774 * fwnode_handle_get - Obtain a reference to a device node
e7887c284969a23 Sakari Ailus 2017-03-28 775 * @fwnode: Pointer to the device node to obtain the reference to.
cf89a31ca55272e Sakari Ailus 2017-09-19 776 *
cf89a31ca55272e Sakari Ailus 2017-09-19 777 * Returns the fwnode handle.
e7887c284969a23 Sakari Ailus 2017-03-28 778 */
477683439b5ee09 Andy Shevchenko 2022-04-08 779 struct fwnode_handle *fwnode_handle_get(const struct fwnode_handle *fwnode)
e7887c284969a23 Sakari Ailus 2017-03-28 780 {
cf89a31ca55272e Sakari Ailus 2017-09-19 781 if (!fwnode_has_op(fwnode, get))
cf89a31ca55272e Sakari Ailus 2017-09-19 @782 return fwnode;
cf89a31ca55272e Sakari Ailus 2017-09-19 783
cf89a31ca55272e Sakari Ailus 2017-09-19 784 return fwnode_call_ptr_op(fwnode, get);
e7887c284969a23 Sakari Ailus 2017-03-28 785 }
e7887c284969a23 Sakari Ailus 2017-03-28 786 EXPORT_SYMBOL_GPL(fwnode_handle_get);
e7887c284969a23 Sakari Ailus 2017-03-28 787
--
0-DAY CI Kernel Test Service
https://01.org/lkp