Re: [PATCH] drm/radeon: change cayman_default_state table from global to static

From: Alex Deucher
Date: Fri Apr 08 2022 - 16:48:42 EST


On Thu, Apr 7, 2022 at 5:47 PM Tom Rix <trix@xxxxxxxxxx> wrote:
>
> cayman_default_state and cayman_default_size are only
> used in ni.c. Single file symbols should be static.
> So move their definitions to cayman_blit_shaders.h
> and change their storage-class-specifier to static.
>
> Remove unneeded cayman_blit_shader.c
>
> cayman_ps/vs definitions were removed with
> commit 4f8629675800 ("drm/radeon/kms: remove r6xx+ blit copy routines")
> So their declarations in cayman_blit_shader.h
> are not needed, so remove them.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Applied. Thanks!

Alex