Re: [PATCH v4 2/2] leds: ktd2692: Make aux-gpios optional
From: Marion & Christophe JAILLET
Date: Fri Apr 08 2022 - 12:58:10 EST
Le 08/04/2022 à 18:33, Markuss Broks a écrit :
Make the AUX pin optional, since it isn't a core part of functionality,
and the device is designed to be operational with only one CTRL pin.
Also pick up maintenance for the LED driver and the yaml bindings.
Signed-off-by: Markuss Broks <markuss.broks@xxxxxxxxx>
---
MAINTAINERS | 6 ++++++
drivers/leds/flash/leds-ktd2692.c | 7 +++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2db49ea7ae55..8ef5667a1d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10479,6 +10479,12 @@ S: Maintained
F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
F: drivers/video/backlight/ktd253-backlight.c
+KTD2692 FLASH LED DRIVER
+M: Markuss Broks <markuss.broks@xxxxxxxxx>
+S: Maintained
+F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml
+F: drivers/leds/flash/leds-ktd2692.yaml
+
KTEST
M: Steven Rostedt <rostedt@xxxxxxxxxxx>
M: John Hawley <warthog9@xxxxxxxxxxxxxx>
diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
index f341da1503a4..26edf41dfa7d 100644
--- a/drivers/leds/flash/leds-ktd2692.c
+++ b/drivers/leds/flash/leds-ktd2692.c
@@ -284,10 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
return ret;
}
- led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
- ret = PTR_ERR_OR_ZERO(led->aux_gpio);
- if (ret) {
- dev_err(dev, "cannot get aux-gpios %d\n", ret);
+ led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS);
+ if (IS_ERR(led->aux_gpio)) {
+ dev_err(dev, "cannot get aux-gpios: %d\n", ret);
return ret;
Hi,
'ret' is known to be 0 at this point.
maybe adding:
ret = PTR_ERR(led->aux_gpio);
?
CJ
}