Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties

From: Kunihiko Hayashi
Date: Fri Apr 08 2022 - 12:14:20 EST


Hi Rob,

On 2022/04/08 3:59, Rob Herring wrote:
On Thu, Apr 07, 2022 at 04:44:07PM +0900, Kunihiko Hayashi wrote:
This refers common bindings, so this is preferred for
unevaluatedProperties instead of additionalProperties.

Yes and no. If you want to define specific common properties are used
(and not used), then listing them in the specific schema with
'additionalProperties' is the right way to do that. If all properties in
the referenced schema are valid, then unevaluatedProperties is correct.

I understand that having a reference to a common schema isn't a direct reason
to replace with unevaluatedProperties because it depends on how each property
of the common schema is handled in this schema.

Since there is no property to evaluate with "if" etc., I think that it can
be left as "additionalProperties" in this schema.
I withdraw this patch.

If we wanted using unevaluatedProperties to be a hard rule, we could
make the meta-schema enforce that.

At the moment it is difficult to decide it to be a hard rule.

Thank you,

---
Best Regards
Kunihiko Hayashi