Re: [PATCH v3] staging: rtl8723bs: tidy up error handling

From: Dan Carpenter
Date: Fri Apr 08 2022 - 10:59:40 EST


On Fri, Apr 08, 2022 at 07:44:40AM -0700, Yihao Han wrote:
> The check for if rtw_skb_alloc() fails is done twice and is written
> in a confusing way. Move the "if (!recvbuf->pskb)" right after
> the allocation. The "if (recvbuf->pskb)" check can now be deleted
> and the code pulled in one tab.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
> ---
> v2: more extensive cleanup
> v3: edit commit message

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter