Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference

[Simon Ser]

On Friday, April 8th, 2022 at 15:21, Grigory Vasilyev <h0tc0d3@xxxxxxxxx> wrote:

> Simon Ser and Bas Nieuwenhuizen, do you understand that you are
> proposing to make the code less safe in the future? In the future,
> someone might rewrite the code and we'll get an error.

I don't think we should blindly add NULL checks for all functions which
take a pointer as argument. This makes it way more complicated to find
a bug when the function is mis-used. Crashing is better because it
indicates a programmer error. In the future, any new call with a NULL
pointer will produce a clear error.

Using pointers for output values is a common pattern in C, it allows a
function to return multiple values.