Re: [PATCH v2 0/2] staging: rtl8192u: cleanup of ternary and if else statements

From: Dan Carpenter
Date: Fri Apr 08 2022 - 02:40:06 EST


On Thu, Apr 07, 2022 at 08:12:49PM -0500, Rebecca Mckeever wrote:
> These patches replace ternary and if else statements with
> more readable statements. Found with minmax coccinelle script.
>
> ---
> v1 -> v2:
> * Patch 1: "staging: rtl8192u: replace ternary statement with if and
> * assignment"
> * replaced max macro with an if statement followed by an assignment
>
> * Patch 2: "staging: rtl8192u: use min_t/max_t macros instead of if
> * else"
> * changed the type argument in min_t and max_t from u8 to u32
> ---

Looks great. Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter