Re: [PATCH v1 2/7] md/raid5: Un-nest struct raid5_percpu definition

From: Christoph Hellwig
Date: Fri Apr 08 2022 - 02:06:28 EST


On Thu, Apr 07, 2022 at 10:57:08AM -0600, Logan Gunthorpe wrote:
> Sparse reports many warnings of the form:
> drivers/md/raid5.c:1476:16: warning: dereference of noderef expression
>
> This is because all struct raid5_percpu definitions get marked as
> __percpu when really only the pointer in r5conf should have that
> annotation.
>
> Fix this by moving the defnition of raid5_precpu out of the definition
> of struct r5conf.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>