Re: [PATCH v3] libata: Improve ATA queued command allocation

From: Christoph Hellwig
Date: Thu Apr 07 2022 - 09:33:02 EST


> + qc = __ata_qc_from_tag(ap, tag);
> + qc->tag = qc->hw_tag = tag;
> + qc->scsicmd = NULL;
> + qc->ap = ap;
> + qc->dev = dev;
> +
> + ata_qc_reinit(qc);
> +
> + qc->scsicmd = cmd;

My fault, byt we can remove the first qc->scsicmd a nothing looks
at the field before this real initialization.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>