Re: [RFC PATCH v5 089/104] KVM: TDX: Add a placeholder for handler of TDX hypercalls (TDG.VP.VMCALL)

From: Paolo Bonzini
Date: Thu Apr 07 2022 - 09:15:11 EST


On 4/7/22 06:15, Kai Huang wrote:
+static int handle_tdvmcall(struct kvm_vcpu *vcpu)
+{
+ struct vcpu_tdx *tdx = to_tdx(vcpu);
+
+ if (unlikely(tdx->tdvmcall.xmm_mask))
+ goto unsupported;
Put a comment explaining this logic?


This only seems to be necessary for Hyper-V hypercalls, which however are not supported by this series in TDX guests (because the kvm_hv_hypercall still calls kvm_*_read, likewise for Xen).

So for now this conditional can be dropped.

Since