Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support

From: H. Nikolaus Schaller
Date: Thu Apr 07 2022 - 07:16:39 EST


Hi Laurent,

> Am 07.04.2022 um 09:30 schrieb Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>:
>
> Hi Nikolaus,
>
> Thank you for the patch.
>
> On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote:
>> "hdmi-connector.yaml" bindings defines an optional property
>> "ddc-en-gpios" for a single gpio to enable DDC operation.
>>
>> Usually this controls +5V power on the HDMI connector.
>> This +5V may also be needed for HPD.
>>
>> This was not reflected in code but is needed to make the CI20
>> board work.
>>
>> Now, the driver activates the ddc gpio after probe and
>> deactivates after remove so it is "almost on".
>>
>> But only if this driver is loaded (and not e.g. blacklisted
>> as module).
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Added to v18 (which is needed to remove some now redundant patches
and fix a detail in the ingenic-drm driver).

BR and thanks for review,
Nikolaus