Re: [PATCH V3] xtensa: patch_text: Fixup last cpu should be master

[Guo Ren]

On Thu, Apr 7, 2022 at 11:35 AM Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
>
> On Wed, Apr 6, 2022 at 7:28 AM <guoren@xxxxxxxxxx> wrote:
> >
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > These patch_text implementations are using stop_machine_cpuslocked
> > infrastructure with atomic cpu_count. The original idea: When the
> > master CPU patch_text, the others should wait for it. But current
> > implementation is using the first CPU as master, which couldn't
> > guarantee the remaining CPUs are waiting. This patch changes the
> > last CPU as the master to solve the potential risk.
> >
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> > Reviewed-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
> > Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > ---
> >  arch/xtensa/kernel/jump_label.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks. Applied to my xtensa tree.
I've missed the "Fixes:" for stable@xxxxxxxxxxxxxxx, so I would update
v3 to fix it.

>
> -- Max



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/