Re: [PATCH v2] x86/apic: Do apic driver probe for "nosmp" use case

[Thomas Gleixner]

On Wed, Apr 06 2022 at 18:54, Kuppuswamy Sathyanarayanan wrote:
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index b70344bf6600..79b8b521981c 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1419,22 +1419,22 @@ void __init apic_intr_mode_init(void)
>  		return;
>  	case APIC_VIRTUAL_WIRE:
>  		pr_info("APIC: Switch to virtual wire mode setup\n");
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_VIRTUAL_WIRE_NO_CONFIG:
>  		pr_info("APIC: Switch to virtual wire mode setup with no configuration\n");
>  		upmode = true;
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_SYMMETRIC_IO:
>  		pr_info("APIC: Switch to symmetric I/O mode setup\n");
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_SYMMETRIC_IO_NO_ROUTING:
>  		pr_info("APIC: Switch to symmetric I/O mode setup in no SMP routine\n");
> +		upmode = true;

Why? The changelog tells nothing about this change.

And it's not correct because the APIC configuration is there, otherwise
__apic_intr_mode_select() would have returned APIC_VIRTUAL_WIRE_NO_CONFIG.

Thanks,

        tglx