Re: [PATCH 4.14 1/2] ipv6: add missing tx timestamping on IPPROTO_RAW

From: Vladimir Oltean
Date: Wed Apr 06 2022 - 17:07:35 EST


On Wed, Apr 06, 2022 at 03:45:14PM -0400, Willem de Bruijn wrote:
> On Wed, Apr 6, 2022 at 3:30 PM Vladimir Oltean <vladimir.oltean@xxxxxxx> wrote:
> >
> > From: Willem de Bruijn <willemb@xxxxxxxxxx>
> >
> > [ Upstream commit fbfb2321e950918b430e7225546296b2dcadf725 ]
> >
> > Raw sockets support tx timestamping, but one case is missing.
> >
> > IPPROTO_RAW takes a separate packet construction path. raw_send_hdrinc
> > has an explicit call to sock_tx_timestamp, but rawv6_send_hdrinc does
> > not. Add it.
> >
> > Fixes: 11878b40ed5c ("net-timestamp: SOCK_RAW and PING timestamping")
> > Signed-off-by: Willem de Bruijn <willemb@xxxxxxxxxx>
> > Acked-by: Soheil Hassas Yeganeh <soheil@xxxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
>
> For 4.14.y cherry-pick:
>
> Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Thanks.

> Might be good to point out that this is not only a clean cherry-pick
> of the one-line patch, but has to include part of commit a818f75e311c
> ("net: ipv6: Hook into time based transmission") to plumb the
> sockcm_cookie. The rest of that patch is not a candidate for stable,
> so LGTM.

Point out how?