Re: [PATCH v2] selftest/vm clarify error statement in gup_test

From: Shuah Khan
Date: Wed Apr 06 2022 - 17:03:07 EST


On 4/5/22 3:48 PM, Sidhartha Kumar wrote:
Print three possible reasons /sys/kernel/debug/gup_test
cannot be opened to help users of this test diagnose
failures.

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
---
v2:
- Add support for skipping the test due to unmet dependencies.
- Use errno to print a more specific message.
- Add check for root privileges.
- dropped CC to stable.
tools/testing/selftests/vm/gup_test.c | 22 +++++++++++++--
tools/testing/selftests/vm/run_vmtests.sh | 33 ++++++++++++++++-------
2 files changed, 44 insertions(+), 11 deletions(-)


Thank you for fixing the reporting and adding tests for dependencies
and skip conditions.

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah