Re: [PATCH 1/3] dt-bindings: PCI: designware-ep: Increase maxItems of reg and reg-names

From: Rob Herring
Date: Wed Apr 06 2022 - 14:53:33 EST


On Tue, Apr 05, 2022 at 04:51:00PM +0900, Kunihiko Hayashi wrote:
> UniPhier PCIe EP controller has 5 register mappings (dbi, dbi2, link,
> config and atu), so maxItems of "reg" and "reg-names" should allow 5.

Shouldn't that be 'addr_space' rather than 'config'? IIRC, 'config' is
only for the host.

>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> index e59059ab5be0..03f97e7c4089 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml
> @@ -28,11 +28,11 @@ properties:
> versions.
> For designware core version >= 4.80, it may contain ATU address space.
> minItems: 2
> - maxItems: 4
> + maxItems: 5
>
> reg-names:
> minItems: 2
> - maxItems: 4
> + maxItems: 5
> items:
> enum: [dbi, dbi2, config, atu, addr_space, link, atu_dma, appl]
>
> --
> 2.25.1
>
>