Re: [PATCH 5.15 327/913] lib: uninline simple_strntoull() as well

From: Greg Kroah-Hartman
Date: Wed Apr 06 2022 - 11:47:14 EST


On Wed, Apr 06, 2022 at 03:34:52PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 05, 2022 at 09:23:09AM +0200, Greg Kroah-Hartman wrote:
> > From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> >
> > [ Upstream commit 839b395eb9c13ae56ea5fc3ca9802734a72293f0 ]
> >
> > Codegen become bloated again after simple_strntoull() introduction
> >
> > add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-224 (-224)
>
> > -static unsigned long long simple_strntoull(const char *startp, size_t max_chars,
> > - char **endp, unsigned int base)
> > +static noinline unsigned long long simple_strntoull(const char *startp, size_t max_chars, char **endp, unsigned int base)
>
> This patch doesn't fix any bugs, why it is selected?

Easy change to make the kernel a tiny bit smaller?