Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192

From: AngeloGioacchino Del Regno
Date: Wed Apr 06 2022 - 09:42:28 EST


Il 06/04/22 12:48, Rex-BC Chen ha scritto:
On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote:
Il 06/04/22 11:46, Rex-BC Chen ha scritto:
The driver data for MT8192 is the same with MT8183. Therefore, we
correct it.

Signed-off-by: Rex-BC Chen <rex-bc.chen@xxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <
angelogioacchino.delregno@xxxxxxxxxxxxx>

...though, from what I know, you should also move MT8195 down there!

Hello Angelo,

Thanks for your review.
But for MT8195, disp_aal is using the same compatible with MT8173.

From the MT8195 project DTS is using:

aal0: disp_aal@1c005000 {
compatible = "mediatek,mt8195-disp-aal",
"mediatek,mt8173-disp-aal";
reg = <0 0x1c005000 0 0x1000>;
interrupts = <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH 0>;
power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>;
mediatek,gce-client-reg =
<&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>;
};

BRs,
Rex


I'm sorry Rex, I've just realized - I was confusing this one with the
8195 gamma binding instead!

Cheers,
Angelo