Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding

From: Jakub Kicinski
Date: Tue Apr 05 2022 - 22:23:56 EST


On Sun, 3 Apr 2022 16:10:19 +0300 Ido Schimmel wrote:
> On Sat, Apr 02, 2022 at 08:15:16AM -0400, Tom Rix wrote:
> > The setting of i here
> > err_nexthop6_group_get:
> > i = nrt6;
> > Is redundant, i is already nrt6. So remove
> > this statement.
> >
> > The for loop for the unwinding
> > err_rt6_create:
> > for (i--; i >= 0; i--) {
> > Is equivelent to
> > for (; i > 0; i--) {
> >
> > Two consecutive labels can be reduced to one.
> >
> > Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
>
> For net-next:
>
> Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>

Now 6f2f36e5f932 ("mlxsw: spectrum_router: simplify list unwinding")
Thanks!