Re: [PATCH v2] staging: rtl8723bs: fix indentation

From: Sevinj Aghayeva
Date: Tue Apr 05 2022 - 21:56:49 EST


On Tue, Apr 5, 2022 at 11:19 AM Sevinj Aghayeva
<sevinj.aghayeva@xxxxxxxxx> wrote:
>
> On Tue, Apr 5, 2022 at 11:17 AM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> > > Adhere to Linux kernel coding style.
> > >
> > > Reported by checkpatch:
> > >
> > > WARNING: suspect code indent for conditional statements
> >
> > You are also removing unneeded comments, right? Please explain that as
> > the documentation link the bot pointed you to showed.
>
> I specified that under the --- line:
>
> v1 -> v2: Remove the comments that became irrelevant with proper indentation.

I think I misunderstood the bot's response. It looks like you
triggered it because you wanted me to write a more complete
description of what the commit is doing. I thought I received it
because it was the second version of the patch from a previous
patchset (the last bullet point in the bot response) that didn't
include v2 in the subject and a v1 -> v2 after the --- line.

I can do a fresh patch with a complete description and no v2 stuff;
please let me know.

Thanks

>
> >
> > thanks,
> >
> > greg k-h
>
>
>
> --
>
> Sevinj.Aghayeva



--

Sevinj.Aghayeva