Re: [PATCH v2 1/1] gpiolib: Get rid of redundant 'else'

From: Bartosz Golaszewski
Date: Tue Apr 05 2022 - 19:11:32 EST


On Wed, Mar 30, 2022 at 5:06 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> In the snippets like the following
>
> if (...)
> return / goto / break / continue ...;
> else
> ...
>
> the 'else' is redundant. Get rid of it. In case of IOCTLs use
> switch-case pattern that seems the usual in such cases.
>
> While at it, clarify necessity of else in gpiod_direction_output()
> by attaching else if to the closing curly brace on a previous line.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---

Applied, thanks!

Bart