Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add lpass cpu node

From: Srinivasa Rao Mandadapu
Date: Tue Apr 05 2022 - 00:50:44 EST



On 3/22/2022 1:22 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
Quoting Srinivasa Rao Mandadapu (2022-03-21 05:28:15)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 499299a..e6ec334 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -19,6 +19,7 @@
#include <dt-bindings/reset/qcom,sdm845-aoss.h>
#include <dt-bindings/reset/qcom,sdm845-pdc.h>
#include <dt-bindings/soc/qcom,rpmh-rsc.h>
+#include <dt-bindings/sound/qcom,lpass.h>
#include <dt-bindings/thermal/thermal.h>

/ {
@@ -1980,6 +1981,68 @@
#clock-cells = <1>;
};

+ lpass_cpu: audio-subsystem@3260000 {
The unit address should match the first reg address. This should be
3987000. By the way, 'subsystem' looks redundant. Maybe just
'audio@3987000' or 'subsystem@3987000'?
Okay. Will change accordingly.