Re: [PATCH] Revert "clk: Drop the rate range on clk_put()"

From: Stephen Boyd
Date: Mon Apr 04 2022 - 17:52:00 EST


Quoting Maxime Ripard (2022-04-04 00:29:00)
> On Sat, Apr 02, 2022 at 07:28:18PM -0700, Stephen Boyd wrote:
> > This reverts commit 7dabfa2bc4803eed83d6f22bd6f045495f40636b. There are
> > multiple reports that this breaks boot on various systems. The common
> > theme is that orphan clks are having rates set on them when that isn't
> > expected. Let's revert it out for now so that -rc1 boots.
> >
> > Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > Reported-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > Reported-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/366a0232-bb4a-c357-6aa8-636e398e05eb@xxxxxxxxxxx
> > Cc: Maxime Ripard <maxime@xxxxxxxxxx>
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>
>
> I really like the attention it's getting now that it's broken, we can
> fix a lot of things :)

Sure! Except that can quickly turn into other attention.

>
> It doesn't seem to be restricted to orphan clocks though :/

Oof ok. I was busy last week so couldn't pay much attention.

>
> But obviously,
> Acked-by: Maxime Ripard <maxime@xxxxxxxxxx>

Thanks. Looks like it just made -rc1 so we can work through the fix at a
more leisurely pace now.