Re: [PATCH] fs/buffer.c: remove unneeded code

[Nick Desaulniers]

On Sat, Apr 2, 2022 at 1:47 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
>
> fix clang warning: Value stored to 'err' is never read in line 2944.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>

The change LGTM, but next time please consider putting the exact text
of the warning observed in the commit message.  For instance, it's not
clear to me whether this was a compiler warning via -W flag, or a
DeadStore warning from clang-tidy.

Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
>  fs/buffer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index bfc566de36e5..b2045871e81c 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2941,7 +2941,6 @@ int block_truncate_page(struct address_space *mapping,
>                 pos += blocksize;
>         }
>
> -       err = 0;
>         if (!buffer_mapped(bh)) {
>                 WARN_ON(bh->b_size != blocksize);
>                 err = get_block(inode, iblock, bh, 0);
> --
> 2.25.1
>


-- 
Thanks,
~Nick Desaulniers