Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR

From: Smita Koralahalli
Date: Mon Apr 04 2022 - 17:25:29 EST


On 4/3/2022 1:44 PM, Borislav Petkov wrote:
On Sun, Apr 03, 2022 at 09:58:07PM +0200, Thomas Gleixner wrote:
How is __always_inline supposed to work across compilation units w/o
LTO? The callsite is in core.c ...
Hmm, right.

So even with patch 3 adding more changes to that function I think it is
still simple enough so that we can move it up into the mce/internal.h
header so that the inlining can work.
Ok will incorporate all changes.

I didn't quite understand what needs to be moved to mce/internal.h. Was that
addressed to me?  The function call smca_extract_err_addr() is in mce/core.c
and the definition in mce.h

Thx.