Re: [pza:reset/next 11/11] drivers/reset/core.c:1114:22: error: implicit declaration of function 'acpi_has_method'; did you mean 'acpi_has_watchdog'?

From: Philipp Zabel
Date: Mon Apr 04 2022 - 10:01:12 EST


On Mo, 2022-04-04 at 21:25 +0800, kernel test robot wrote:
> tree:   https://git.pengutronix.de/git/pza/linux reset/next
> head:   7272ce0fa39b66aa91c934a27e9196082a3ffc40
> commit: 7272ce0fa39b66aa91c934a27e9196082a3ffc40 [11/11] reset: ACPI
> reset support
> config: h8300-randconfig-m031-20220404 (
> https://download.01.org/0day-ci/archive/20220404/202204042122.vBjzQg7a-lkp@xxxxxxxxx/config
> )
> compiler: h8300-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>  -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git remote add pza https://git.pengutronix.de/git/pza/linux
>         git fetch --no-tags pza reset/next
>         git checkout 7272ce0fa39b66aa91c934a27e9196082a3ffc40
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0
> make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/reset/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
>    drivers/reset/core.c: In function '__device_reset':
> > > drivers/reset/core.c:1114:22: error: implicit declaration of
> > > function 'acpi_has_method'; did you mean 'acpi_has_watchdog'? [-
> > > Werror=implicit-function-declaration]
>     1114 |                 if (!acpi_has_method(handle, "_RST"))
>          |                      ^~~~~~~~~~~~~~~
>          |                      acpi_has_watchdog
>    cc1: some warnings being treated as errors

Apologies, I should have caught this. Unfortunately we are missing
stubs for the ACPI functions. I'll fix it up by wrapping the new code
in #ifdef CONFIG_ACPI.

regards
Philipp