Re: [PATCH v2 1/2] block: add sync_blockdev_range()

[Christoph Hellwig]

On Sat, Apr 02, 2022 at 03:28:00AM +0000, Yuezhang.Mo@xxxxxxxx wrote:
> sync_blockdev_range() is to support syncing multiple sectors
> with as few block device requests as possible, it is helpful
> to make the block device to give full play to its performance.
> 
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@xxxxxxxx>
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Reviewed-by: Andy Wu <Andy.Wu@xxxxxxxx>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@xxxxxxxx>
> cc: Jens Axboe <axboe@xxxxxxxxx>
> ---
>  block/bdev.c           | 10 ++++++++++
>  include/linux/blkdev.h |  6 ++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/block/bdev.c b/block/bdev.c
> index 102837a37051..57043e4f3322 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -200,6 +200,16 @@ int sync_blockdev(struct block_device *bdev)
>  }
>  EXPORT_SYMBOL(sync_blockdev);
>  
> +int sync_blockdev_range(struct block_device *bdev, loff_t lstart, loff_t lend)
> +{
> +	if (!bdev)
> +		return 0;

This check isn't really needed, and I don't think we need a
!CONFIG_BLOCK stub for this either.