Re: [PATCH] net: phy: marvell: add 88E1543 support

From: Andrew Lunn
Date: Sun Apr 03 2022 - 15:54:57 EST


On Sun, Apr 03, 2022 at 08:01:33PM +0100, Russell King (Oracle) wrote:
> On Sun, Apr 03, 2022 at 09:30:06PM +0300, Stijn Tintel wrote:
> > On 3/04/2022 21:19, Russell King (Oracle) wrote:
> > > Hi,
> > >
> > > On Sun, Apr 03, 2022 at 08:29:36PM +0300, Stijn Tintel wrote:
> > >> Add support for the Marvell Alaska 88E1543 PHY used in the WatchGuard
> > >> Firebox M200 and M300.
> > > Looking at the IDs, this PHY should already be supported - reporting as
> > > an 88E1545. Why do you need this patch?
> > >
> > Thanks for pointing that out, you're right. Please disregard the patch. 
> > Would it be acceptable to change the name member to "Marvell
> > 88E1543/88E1545" to make this more obvious?
>
> Unfortuantely not, the driver name is used in sysfs, and as I'm sure
> you're aware, "/" is a pathname element separator and thus can't be
> used.

The name is however reasonably free text. For example:

micrel.c: .name = "Micrel KSZ8021 or KSZ8031",

Andrew