Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function

From: Greg Kroah-Hartman
Date: Sun Apr 03 2022 - 07:16:37 EST

Next message: Pavel Skripkin: "Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp."
Previous message: Greg KH: "Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp."
In reply to: kernel test robot: "Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function"
Next in thread: Philipp Hortmann: "[PATCH 6/7] staging: vt6655: Rename macros VNSvOutPortB,W,D"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Apr 02, 2022 at 09:29:49AM +0200, Philipp Hortmann wrote:
> Convert do-while(0) macro PCAvDelayByIO to function and relocate.

That says what you did, but not _why_ you did it.

Please read the kernel documentation again for how to write a good
changelog comment and resend a v2.

thanks,

greg k-h

Next message: Pavel Skripkin: "Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp."
Previous message: Greg KH: "Re: [PATCH] staging: r8188eu: Fix unsafe memory access by memcmp."
In reply to: kernel test robot: "Re: [PATCH 7/7] staging: vt6655: Convert macro PCAvDelayByIO to function"
Next in thread: Philipp Hortmann: "[PATCH 6/7] staging: vt6655: Rename macros VNSvOutPortB,W,D"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]