Re: [PATCH] staging: r8188eu: Fix PPPoE tag insertion on big endian systems

[Larry Finger]

On 4/1/22 14:25, Guenter Roeck wrote:
> The rest of the code uses htons/ntohs, so I prefer to follow that lead.

You just proved my point. It is hard to get be16_to_cpu() wrong. Sparse will 
flag the error when you use cpu_to_be16() instead. I expect that your 
htons/ntohs problem would also have shown up with Sparse.

Larry