Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

From: Andy Shevchenko
Date: Fri Apr 01 2022 - 09:45:04 EST


On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.

...

> + NULL, /* 0x10 */

I would suggest to add the comments more often, like every 8 entries.

...

> + "FSI_VMON" /* 0x25 */

It would be good to have comma here as if this ever getting expanded
the additional churn may be avoided.

> };

--
With Best Regards,
Andy Shevchenko