Re: [PATCH v2 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

[Lee Jones]

On Fri, 01 Apr 2022, Lee Jones wrote:

> This ensures userspace cannot prematurely clean-up the client before
> it is fully initialised which has been proven to cause issues in the
> past.
> 
> Cc: Felix Kuehling <Felix.Kuehling@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> 
> CAVEAT: This patch is completely untested
>         I can't seem to find a configuration strategy to compile test this
>         allyesconfig and allmodconfig do not appear sufficient
> 
> v2: Also remove Client from RCU list in error path
> 
>  drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 24 +++++++++++++--------
>  1 file changed, 15 insertions(+), 9 deletions(-)

Please ignore this re-submission, script error.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog