Re: [PATCH v2 1/2] hugetlb: Fix hugepages_setup when deal with pernode

[David Hildenbrand]

On 01.04.22 12:12, Peng Liu wrote:
> Hugepages can be specified to pernode since "hugetlbfs: extend
> the definition of hugepages parameter to support node allocation",
> but the following problem is observed.
> 
> Confusing behavior is observed when both 1G and 2M hugepage is set
> after "numa=off".
>  cmdline hugepage settings:
>   hugepagesz=1G hugepages=0:3,1:3
>   hugepagesz=2M hugepages=0:1024,1:1024
>  results:
>   HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages
>   HugeTLB registered 2.00 MiB page size, pre-allocated 1024 pages
> 
> Furthermore, confusing behavior can be also observed when invalid
> node behind valid node.
> 
> To fix this, hugetlb_hstate_alloc_pages should be called even when
> hugepages_setup going to invalid.

Shouldn't we bail out if someone requests node-specific allocations but
we are not running with NUMA?

What's the result after your change?

> 
> Cc: <stable@xxxxxxxxxxxxxxx>

I am not sure if this is really stable material.

> Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")
> Signed-off-by: Peng Liu <liupeng256@xxxxxxxxxx>

-- 
Thanks,

David / dhildenb