Re: [PATCH v2] efi: Allow to enable EFI runtime services by default on RT

From: Javier Martinez Canillas
Date: Fri Apr 01 2022 - 04:38:53 EST


Hello Ard,

On 4/1/22 10:34, Ard Biesheuvel wrote:
> On Fri, 1 Apr 2022 at 10:33, Javier Martinez Canillas
> <javierm@xxxxxxxxxx> wrote:

[snip]

>>
>> if (!efi_enabled(EFI_RUNTIME_SERVICES))
>> efi.runtime_supported_mask = 0;
>> + else if (IS_ENABLED(CONFIG_PREEMPT_RT))
>> + pr_warn("EFI runtime services can lead to high latencies on Real-Time kernels\n");
>>
>> if (!efi_enabled(EFI_BOOT))
>> return 0;
>>
>
>
> I don't think we need another warning.
>
> The kernel log already tells you whether or not EFI runtime services
> are enabled.
>

I'm fine with this too. As mentioned to Ahmed I was torn on this, since I
understand the ask for the warning but also don't want to pollute the log.

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat