RE: [PATCH V6 4/5] mailbox: imx: support dual interrupts

[Peng Fan]

> Subject: Re: [PATCH V6 4/5] mailbox: imx: support dual interrupts
> 
> Hi,
> 
> On Tue, Mar 1, 2022 at 8:23 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> wrote:
> >
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > i.MX93 S401 MU support two interrupts: tx empty and rx full.
> >
> >  - Introduce a new flag IMX_MU_V2_IRQ for the dual interrupt case
> >  - Update author and Copyright
> >
> Copyright update is fair.
> However, I am not sure adding an extra interrupt warrants co-authorship,
> otherwise people submit far bigger changes to drivers.

I just thought I did lots of changes to this driver and just add my authorship
here. That's fine, I'll drop.

> And you didn't even CC the original author Oleksij Rempel. At least please
> seek his ACK.

I just use scripts/get_maintainers script, will add Oleksij.

> 
> > diff --git a/drivers/mailbox/imx-mailbox.c
> > b/drivers/mailbox/imx-mailbox.c index 03699843a6fd..4bc59a6cad20
> > 100644
> > --- a/drivers/mailbox/imx-mailbox.c
> > +++ b/drivers/mailbox/imx-mailbox.c
> ....
> >
> > +/* Please not change TX & RX */
> >  enum imx_mu_chan_type {
> >         IMX_MU_TYPE_TX,         /* Tx */
> >         IMX_MU_TYPE_RX,         /* Rx */
> >
> You want to hard-code the values to make it clearer
>       IMX_MU_TYPE_TX = 0,
>       IMX_MU_TYPE_RX = 1,
> 
> 
> > @@ -536,7 +539,8 @@ static int imx_mu_startup(struct mbox_chan *chan)
> > {
> >         struct imx_mu_priv *priv = to_imx_mu_priv(chan->mbox);
> >         struct imx_mu_con_priv *cp = chan->con_priv;
> > -       unsigned long irq_flag = IRQF_SHARED;
> > +       unsigned long irq_flag = 0;
> > +       int irq;
> >         int ret;
> >
> >         pm_runtime_get_sync(priv->dev); @@ -551,11 +555,16 @@
> static
> > int imx_mu_startup(struct mbox_chan *chan)
> >         if (!priv->dev->pm_domain)
> >                 irq_flag |= IRQF_NO_SUSPEND;
> >
> > -       ret = request_irq(priv->irq[0], imx_mu_isr, irq_flag,
> > -                         cp->irq_desc, chan);
> > +       if (priv->dcfg->type & IMX_MU_V2_IRQ) {
> > +               irq = priv->irq[cp->type];
> > +       } else {
> > +               irq = priv->irq[0];
> >
> Please use some verbose define instead of the magic 0.

Fix in V7.

Thanks,
Peng.

> 
> Thanks.