Re: [PATCH 0/4] Branch stack improvements

From: Arnaldo Carvalho de Melo
Date: Mon Mar 07 2022 - 12:54:08 EST


Em Mon, Mar 07, 2022 at 05:19:13PM +0000, James Clark escreveu:
> I came across a few generic non-Arm issues when reviewing Anshuman's new
> support for branch record buffers on Arm [1].
>
> The first one is a fix to an error message which is misleading if the
> feature is unavailable and the remaining ones make the branch type field
> visible in perf report and perf script so that it can be debugged or used
> by other tools.
>
> Applies to perf/core (56dce86819)

Thanks, applied to tmp.perf/core, locally, if someone spots some
problem, there is some time till I run tests and move it to perf/core.

- Arnaldo

> Thanks
> James
>
> [1] https://lore.kernel.org/lkml/1642998653-21377-1-git-send-email-anshuman.khandual@xxxxxxx/
>
> James Clark (4):
> perf: Add error message for unsupported branch stack cases
> perf: Print branch stack entry type in --dump-raw-trace
> perf: Refactor perf script branch stack printing
> perf script: Output branch sample type
>
> tools/perf/builtin-script.c | 28 +++++++++++++---------------
> tools/perf/util/evsel.c | 4 ++++
> tools/perf/util/session.c | 5 +++--
> 3 files changed, 20 insertions(+), 17 deletions(-)
>
> --
> 2.28.0

--

- Arnaldo