Re: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support

From: Andy Shevchenko
Date: Mon Mar 07 2022 - 08:45:57 EST


On Mon, Mar 07, 2022 at 05:01:47PM +0530, shruthi.sanil@xxxxxxxxx wrote:
> From: Shruthi Sanil <shruthi.sanil@xxxxxxxxx>
>
> The Intel Keem Bay timer driver supports clocksource and clockevent
> features for the timer IP used in Intel Keem Bay SoC.
> The timer block supports 1 free running counter and 8 timers.
> The free running counter can be used as a clocksource and
> the timers can be used as clockevent. Each timer is capable of
> generating individual interrupt.
> Both the features are enabled through the timer general config register.

...

> + pr_err("%pOF: FW_BUG: Prescaler is not enabled\n", np);

FW_BUG is a macro. The above is an incorrect use of it.

...

> + pr_err("%pOF: FW_BUG: free running counter is not enabled\n", np);

Ditto.

--
With Best Regards,
Andy Shevchenko