Re: [PATCH 13/16] mm/migration: return errno when isolate_huge_page failed

From: Miaohe Lin
Date: Mon Mar 07 2022 - 06:47:39 EST


On 2022/3/5 10:23, Muchun Song wrote:
> On Fri, Mar 4, 2022 at 5:36 PM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>>
>> We should return errno (-EBUSY here) when failed to isolate the huge page
>> rather than always return 1 which could confuse the user.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
> IIUC, this should be a bug fix since the status reported to the user is
> wrong. A Fixes tag may be needed. But anyway:
>

Agree. Thanks for pointing this out and many thanks for your review. :)

> Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
>
> Thanks.
>
> .
>