Re: [PATCH] rtc: optee: add RTC driver for OP-TEE RTC PTA

From: Clément Léger
Date: Mon Mar 07 2022 - 05:46:33 EST


Le Sun, 6 Mar 2022 22:08:48 +0100,
Etienne Carriere <etienne.carriere@xxxxxxxxxx> a écrit :

> Hello Clement,
>
> In the code, rtc-optee driver opens a session with optee and allocates
> shared memory from probe to remove time.
> This uses resources in the TEE but RTC is not accessed often by Linux I guess.
> Would it be interesting if a session is opened and shared memory
> allocated only when a RPC command is to be invoked?

Hi Etienne, that is an idea that could be added later I guess ?

>
> Minor comments below.

Thanks for the review.

--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com