Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD

From: Niklas Söderlund
Date: Mon Mar 07 2022 - 04:33:03 EST


Hi Guo,

Thanks for your work.

On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <guozhengkui@xxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>

> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>
> if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
> NL_SET_ERR_MSG_MOD(extack,
> - "XSK buffer pool chunk size too small\n");
> + "XSK buffer pool chunk size too small");
> return -EINVAL;
> }
> }
> --
> 2.20.1
>

--
Regards,
Niklas Söderlund