Re: [PATCH 1/6] KVM: fix checkpatch warnings

From: Joe Perches
Date: Sat Mar 05 2022 - 15:35:06 EST


On Sat, 2022-03-05 at 15:26 -0500, Henry Sloan wrote:
> Fix "SPDX comment style" warnings

Hi.

You've given all these patches the same email subject line.

That would mean the commit subject line would also be the same
for each of these 6 patches.

That's bad.

More proper would be to use the first line of each commit
message as part of the subject line

i.e.: This subject line would become:

Subject: [PATCH 1/6] KVM: Fix "SPDX comment style" warnings

or perhaps better:

Subject: [PATCH 1/6] KVM: Use typical SPDX comment style

etc...

>
> This patchset fixes many checkpatch warnings in the virt/kvm directory.

And this bit doesn't belong in the first patch of 6, but in a 0/6
patch cover letter.

cheers, Joe