Re: [PATCH] iio:adc:twl6030: Use of_device_get_match_data()

[Jonathan Cameron]

On Fri,  4 Mar 2022 01:59:32 +0000
cgel.zte@xxxxxxxxx wrote:

> From: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx>
> 
> Use of_device_get_match_data() to simplify the code.
> 
> v1->v2:
>   iio:adc:->iio:adc:twl6030:
Hi,

For IIO please put the change log below the ---
A few areas of the kernel do this differently but we are consistent
in using link tags (generated when I apply the patch) to give
access to change logs rather than having them stored for ever
in the main git log.

> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx>

You haven't addressed my request in reply to previous posting
to use device_get_match_data() and switch to the generic
properties interfaces.  I'd rather see that done in one step
then going via this cleanup.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index afdb59e0b526..6a022e583658 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -867,16 +867,11 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct twl6030_gpadc_data *gpadc;
>  	const struct twl6030_gpadc_platform_data *pdata;
> -	const struct of_device_id *match;
>  	struct iio_dev *indio_dev;
>  	int irq;
>  	int ret;
>  
> -	match = of_match_device(of_twl6030_match_tbl, dev);
> -	if (!match)
> -		return -EINVAL;
> -
> -	pdata = match->data;
> +	pdata = of_device_get_match_data(dev);
>  
>  	indio_dev = devm_iio_device_alloc(dev, sizeof(*gpadc));
>  	if (!indio_dev)