Re: [PATCH 03/19] context_tracking: Rename context_tracking_enter/exit() to ct_user_enter/exit()

From: Peter Zijlstra
Date: Sat Mar 05 2022 - 09:11:59 EST


On Wed, Mar 02, 2022 at 04:47:54PM +0100, Frederic Weisbecker wrote:
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index 83e050675b23..e8e58c10f135 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -103,7 +103,7 @@ void noinstr __ct_user_enter(enum ctx_state state)
> }
> EXPORT_SYMBOL_GPL(__ct_user_enter);
>
> -void context_tracking_enter(enum ctx_state state)
> +void ct_user_enter(enum ctx_state state)
> {
> unsigned long flags;
>
> @@ -122,8 +122,8 @@ void context_tracking_enter(enum ctx_state state)
> __ct_user_enter(state);
> local_irq_restore(flags);
> }
> -NOKPROBE_SYMBOL(context_tracking_enter);
> -EXPORT_SYMBOL_GPL(context_tracking_enter);
> +NOKPROBE_SYMBOL(ct_user_enter);
> +EXPORT_SYMBOL_GPL(ct_user_enter);
>
> /**
> * user_enter_callable() - Unfortunate ASM callable version of user_enter() for
> @@ -173,7 +173,7 @@ void noinstr __ct_user_exit(enum ctx_state state)
> }
> EXPORT_SYMBOL_GPL(__ct_user_exit);
>
> -void context_tracking_exit(enum ctx_state state)
> +void ct_user_exit(enum ctx_state state)
> {
> unsigned long flags;
>
> @@ -184,8 +184,8 @@ void context_tracking_exit(enum ctx_state state)
> __ct_user_exit(state);
> local_irq_restore(flags);
> }
> -NOKPROBE_SYMBOL(context_tracking_exit);
> -EXPORT_SYMBOL_GPL(context_tracking_exit);
> +NOKPROBE_SYMBOL(ct_user_exit);
> +EXPORT_SYMBOL_GPL(ct_user_exit);
>
> /**
> * user_exit_callable() - Unfortunate ASM callable version of user_exit() for

Why is it NOKPROBE but not notrace, also local_irq_*() include explicit
tracepoints.