Re: [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

From: Byungchul Park
Date: Fri Mar 04 2022 - 18:37:05 EST


On Fri, Mar 04, 2022 at 10:28:57PM +0300, Sergei Shtylyov wrote:
> On 3/4/22 10:06 AM, Byungchul Park wrote:
>
> > cb92173d1f0 (locking/lockdep, cpu/hotplug: Annotate AP thread) was
>
> You need to enclose the commit summary in (""), not just (). :-)

Thank you! I will!

> > introduced to make lockdep_assert_cpus_held() work in AP thread.
> >
> > However, the annotation is too strong for that purpose. We don't have to
> > use more than try lock annotation for that.
> >
> > Furthermore, now that Dept was introduced, false positive alarms was
> > reported by that. Replaced it with try lock annotation.
> >
> > Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
> [...]
>
> MBR, Sergey