Re: [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver

From: Takashi Iwai
Date: Fri Mar 04 2022 - 12:05:32 EST


On Fri, 04 Mar 2022 16:07:01 +0100,
Lucas Tanure wrote:
>
> Move the support for CS35L41 external boost to its shared library
> for ASoC use.
> This move resulted in cs35l41_hda_reg_sequence being removed,
> and its steps were broken down into regmap writes or functions
> from the library. And hardware configuration struct was unified
> for its use in the shared lib.
> While at it, some minor bugs were found and fixed it.
>
> v2 changelog:
> - Instead of removing the log, playback actions will log the last regmap access.
> - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the
> provided example.
>
> Previous versions:
> v1: https://lkml.org/lkml/2022/3/3/759
>
> David Rhodes (2):
> ASoC: cs35l41: Fix GPIO2 configuration
> ASoC: cs35l41: Document CS35l41 External Boost
>
> Lucas Tanure (18):
> ASoC: cs35l41: Fix max number of TX channels
> ASoC: cs35l41: Fix DSP mbox start command and global enable order
> ASoC: cs35l41: Remove unnecessary param
> sound: cs35l41: Unify hardware configuration
> sound: cs35l41: Check hw_config before using it
> sound: cs35l41: Move cs35l41_gpio_config to shared lib
> hda: cs35l41: Fix I2S params comments
> hda: cs35l41: Always configure the DAI
> hda: cs35l41: Add Boost type flag
> hda: cs35l41: Put the device into safe mode for external boost
> hda: cs35l41: Mute the device before shutdown
> sound: cs35l41: Enable Internal Boost in shared lib
> hda: cs35l41: Move boost config to initialization code
> hda: cs35l41: Remove cs35l41_hda_reg_sequence struct
> hda: cs35l41: Reorganize log for playback actions
> hda: cs35l41: Handle all external boost setups the same way
> hda: cs35l41: Move external boost handling to lib for ASoC use
> ASoC: cs35l41: Support external boost

Through a quick glance, the code changes look OK in general.
But please correct the subject prefix. For non-ASoC patches (that
begin with either "hda" or "sound" in this patch set) should be with
"ALSA: hda: xxx" or such.

Also, although I respect the spirit of Haiku, the patch logs could be
a bit more verbose and descriptive, and the texts can be folded at the
right column. Some patch descriptions are too short, e.g. patch 15
doesn't mention about the new usleep_range() addition in the code.


thanks,

Takashi