Re: [PATCH 2/2] nvme-tcp: support specifying the congestion-control

From: Christoph Hellwig
Date: Fri Mar 04 2022 - 11:20:40 EST


I'll let the NVMe/TCP maintainer comment on the actual functionality,
but:

> + p = match_strdup(args);
> + if (!p) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + key = tcp_ca_get_key_by_name(NULL, p, &ecn_ca);
> + if (key == TCP_CA_UNSPEC) {
> + pr_err("congestion control %s not found.\n",
> + p);
> + ret = -EINVAL;
> + kfree(p);
> + goto out;
> + }

We can't just call networking code from nvme-fabrics.ko