Re: [PATCH v2 2/3] dt-bindings: remoteproc: Add AVM WASP

From: Krzysztof Kozlowski
Date: Fri Mar 04 2022 - 08:36:46 EST


On 27/02/2022 12:58, Daniel Kestrel wrote:
> AVM Fritzbox router boards may contain an additional ATH79
> based SoC that has the wifi cards connected.
> This patch adds bindings for this remote processor.
>
> Signed-off-by: Daniel Kestrel <kestrelseventyfour@xxxxxxxxx>
> ---
> .../bindings/remoteproc/avm,wasp-rproc.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> new file mode 100644
> index 000000000000..8b39fafc60aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/avm,wasp-rproc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AVM WASP processor controller bindings
> +
> +maintainers:
> + - Daniel Kestrel <kestrelseventyfour@xxxxxxxxx>
> +
> +description: |
> + This document defines the bindings for the remoteproc component that loads and
> + boots firmwares on the AVM Wireless Assistent Support Processor (WASP) SoC
> + that is attached to some AVM Fritzbox devices (3390, 3490, 5490, 5491, 7490).
> +
> +properties:
> + compatible:
> + enum:
> + - avm,fritzbox3390-wasp
> + - avm,fritzboxx490-wasp

This should be specific compatible instead of wildcard "x490".

> +
> + avm,wasp-mdio:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Lantiq GSWIP switch mdio.
> +
> + avm,wasp-port:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Network port, where the WASP SoC is connected to.
> +
> + avm,reset-gpios:
> + description: Reset gpio of the WASP SoC.

maxItems

> +
> + avm,startup-gpios:
> + description: Startup gpio of the WASP SoC.

maxItems

> +
> +required:
> + - compatible
> + - avm,wasp-mdio
> + - avm,wasp-port
> + - avm,reset-gpios
> + - avm,startup-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + remoteproc {
> + compatible = "avm,fritzboxx490-wasp";
> + avm,wasp-mdio = <&gswip_mdio>;
> + avm,wasp-port = <&port5>;
> + avm,reset-gpios = <&gpio 34 GPIO_ACTIVE_HIGH>;
> + avm,startup-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> + };


Best regards,
Krzysztof