Re: [PATCH for-next] RDMA/core: Fix ib_qp_usecnt_dec() called when error

From: Leon Romanovsky
Date: Thu Mar 03 2022 - 14:01:14 EST


On Thu, Mar 03, 2022 at 10:42:32AM +0800, Yajun Deng wrote:
> ib_destroy_qp() would called by ib_create_qp_user() if error, the former
> contains ib_qp_usecnt_dec(), but ib_qp_usecnt_inc() was not called before.
>
> So move ib_qp_usecnt_inc() into create_qp().
>
> Fixes: d2b10794fc13 ("RDMA/core: Create clean QP creations interface for uverbs")
> Signed-off-by: Yajun Deng <yajun.deng@xxxxxxxxx>
> ---
> drivers/infiniband/core/uverbs_cmd.c | 1 -
> drivers/infiniband/core/uverbs_std_types_qp.c | 1 -
> drivers/infiniband/core/verbs.c | 3 +--
> 3 files changed, 1 insertion(+), 4 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>