Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit

[Shuah Khan]

On 2/27/22 11:55 PM, Muhammad Usama Anjum wrote:
> Hi,
>
> Andrew had already accepted the patch. I'll send an iteration.
>
> On 2/26/22 5:35 AM, Shuah Khan wrote:
> > > +#define PAGEMAP_PATH        "/proc/self/pagemap"
> >
> > Why is this names PATH - it is the file name right?
> I'll update the names of the macros.
>
> > > +
> > > +int clear_refs;
> > > +int pagemap;
> > > +
> >
> > Get rid of these globals and pass these in - please find name
> > that clearly indicates them as fds
> I'll update their names to indicate fds. This is a standalone test
> application. Shouldn't the usage of global variables be fine?

It makes it harder to maintain. Unless there is reason, avoid globals.
I am not seeing a need for globals in this case, other than convenience.

thanks,
-- Shuah