Re: [PATCH] dmaengine: xilinx_dpdma: fix platform_get_irq.cocci warning

[Michal Simek]

On 3/3/22 14:03, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
> ---
>   drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index b0f4948b00a5..f708808d73ba 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
>   	dpdma_hw_init(xdev);
>   
>   	xdev->irq = platform_get_irq(pdev, 0);
> -	if (xdev->irq < 0) {
> -		dev_err(xdev->dev, "failed to get platform irq\n");
> +	if (xdev->irq < 0)
>   		return xdev->irq;
> -	}
>   
>   	ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
>   			  dev_name(xdev->dev), xdev);


Make sense.

Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal